Conversation
Member
|
I'm not really that knowledgeable about PowerShell. Maybe @exercism/powershell could take a look? |
Member
That's weird. What was the error? |
Comment on lines
+54
to
+59
| if (Get-Command Expand-Archive -ErrorAction SilentlyContinue) { | ||
| Expand-Archive -Path $outputPath -DestinationPath $outputDirectory -Force | ||
| } else { | ||
| Add-Type -AssemblyName System.IO.Compression.FileSystem | ||
| [System.IO.Compression.ZipFile]::ExtractToDirectory($outputPath, $outputDirectory) | ||
| } |
Member
There was a problem hiding this comment.
This looks like it silently fails when Expand-Archive cannot be found, in which case configlet cannot be extracted. I don't think that's what we want?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had problems using the existing script with windows 11 and powershell 5. I updated my ps version to 7.6 and still had errors.
As I don't know powershell, I used AI to finda solution and this seems to work. I am worried about backwards comatibility and general AI use for things I don't understand.
Probably best to let knowledgeable people judge this.